diff options
| author | Michal Hocko <mhocko@suse.cz> | 2014-01-23 15:53:15 -0800 |
|---|---|---|
| committer | Jiri Slaby <jslaby@suse.cz> | 2014-09-26 12:12:57 +0200 |
| commit | 60f09acea19cc0638f87d1beded9a48287a43466 (patch) | |
| tree | c110423ba0a9d95a668d070116d58bfee7bdcfe3 | |
| parent | 7d97f39bc813aa9f11fe03d602885f81de07007c (diff) | |
mm: new_vma_page() cannot see NULL vma for hugetlb pages
commit cc81717ed3bc6d4f3738d13a1e097437caada0e9 upstream.
Commit 11c731e81bb0 ("mm/mempolicy: fix !vma in new_vma_page()") has
removed BUG_ON(!vma) from new_vma_page which is partially correct
because page_address_in_vma will return EFAULT for non-linear mappings
and at least shared shmem might be mapped this way.
The patch also tried to prevent NULL ptr for hugetlb pages which is not
correct AFAICS because hugetlb pages cannot be mapped as VM_NONLINEAR
and other conditions in page_address_in_vma seem to be legit and catch
real bugs.
This patch restores BUG_ON for PageHuge to catch potential issues when
the to-be-migrated page is not setup properly.
Signed-off-by: Michal Hocko <mhocko@suse.cz>
Reviewed-by: Bob Liu <bob.liu@oracle.com>
Cc: Sasha Levin <sasha.levin@oracle.com>
Cc: Wanpeng Li <liwanp@linux.vnet.ibm.com>
Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
| -rw-r--r-- | mm/mempolicy.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/mm/mempolicy.c b/mm/mempolicy.c index 41a42902ef21..3650036bb910 100644 --- a/mm/mempolicy.c +++ b/mm/mempolicy.c @@ -1200,10 +1200,8 @@ static struct page *new_page(struct page *page, unsigned long start, int **x) } if (PageHuge(page)) { - if (vma) - return alloc_huge_page_noerr(vma, address, 1); - else - return NULL; + BUG_ON(!vma); + return alloc_huge_page_noerr(vma, address, 1); } /* * if !vma, alloc_page_vma() will use task or system default policy |