diff options
| author | Li Zefan <lizf@cn.fujitsu.com> | 2008-11-16 11:05:24 -0500 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2008-12-05 10:55:37 -0800 |
| commit | 3f007078d237e1a09db76c18519469b894dccebf (patch) | |
| tree | 9f2ffef221e54bf67cee993678e3fb30768b4495 | |
| parent | e3baeaafd5dd29b2556b697699627fb133ede434 (diff) | |
ext4: add missing unlock in ext4_check_descriptors() on error path
(cherry picked from commit 7ee1ec4ca30c6df8e989615cdaacb75f2af4fa6b)
If there group descriptors are corrupted we need unlock the block
group lock before returning from the function; else we will oops when
freeing a spinlock which is still being held.
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| -rw-r--r-- | fs/ext4/super.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/fs/ext4/super.c b/fs/ext4/super.c index 062b7c5dc68f..f98f9bbf98c1 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -1626,8 +1626,10 @@ static int ext4_check_descriptors(struct super_block *sb) "Checksum for group %lu failed (%u!=%u)\n", i, le16_to_cpu(ext4_group_desc_csum(sbi, i, gdp)), le16_to_cpu(gdp->bg_checksum)); - if (!(sb->s_flags & MS_RDONLY)) + if (!(sb->s_flags & MS_RDONLY)) { + spin_unlock(sb_bgl_lock(sbi, i)); return 0; + } } spin_unlock(sb_bgl_lock(sbi, i)); if (!flexbg_flag) |