diff options
authorNikolay Aleksandrov <nikolay@cumulusnetworks.com>2015-07-13 06:36:19 -0700
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2015-10-01 12:07:36 +0200
commit8d228c93f31c90894fa86c597beb42b67c5ac978 (patch)
parent5fa39f16036eb627fe50a38c307fa99eace26ee3 (diff)
bridge: mdb: fix double add notification
[ Upstream commit 5ebc784625ea68a9570d1f70557e7932988cd1b4 ] Since the mdb add/del code was introduced there have been 2 br_mdb_notify calls when doing br_mdb_add() resulting in 2 notifications on each add. Example: Command: bridge mdb add dev br0 port eth1 grp permanent Before patch: root@debian:~# bridge monitor all [MDB]dev br0 port eth1 grp permanent [MDB]dev br0 port eth1 grp permanent After patch: root@debian:~# bridge monitor all [MDB]dev br0 port eth1 grp permanent Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com> Fixes: cfd567543590 ("bridge: add support of adding and deleting mdb entries") Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 files changed, 0 insertions, 1 deletions
diff --git a/net/bridge/br_mdb.c b/net/bridge/br_mdb.c
index ff61e200bf01..4e76d2a11284 100644
--- a/net/bridge/br_mdb.c
+++ b/net/bridge/br_mdb.c
@@ -345,7 +345,6 @@ static int br_mdb_add_group(struct net_bridge *br, struct net_bridge_port *port,
return -ENOMEM;
rcu_assign_pointer(*pp, p);
- br_mdb_notify(br->dev, port, group, RTM_NEWMDB);
return 0;