diff options
| author | Al Viro <viro@zeniv.linux.org.uk> | 2016-02-27 19:17:33 -0500 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2016-03-03 15:06:24 -0800 |
| commit | 1b153db5ac6c1598022b2b11ffb3be1303e3bffb (patch) | |
| tree | 45fb97e9471374c5cdf53f4574bbfeb8ca11c5eb | |
| parent | b19e7a870c21104186d5834d469b6e4a60d5cc6a (diff) | |
do_last(): don't let a bogus return value from ->open() et.al. to confuse us
commit c80567c82ae4814a41287618e315a60ecf513be6 upstream.
... into returning a positive to path_openat(), which would interpret that
as "symlink had been encountered" and proceed to corrupt memory, etc.
It can only happen due to a bug in some ->open() instance or in some LSM
hook, etc., so we report any such event *and* make sure it doesn't trick
us into further unpleasantness.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | fs/namei.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/fs/namei.c b/fs/namei.c index 157c3dbacf6c..c87e15ee9255 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -2917,6 +2917,10 @@ opened: goto exit_fput; } out: + if (unlikely(error > 0)) { + WARN_ON(1); + error = -EINVAL; + } if (got_write) mnt_drop_write(nd->path.mnt); path_put(&save_parent); |