fix bug in build-info uncovered by 8f2768d

Commit 8f2768d changed the way the search_path and filename were passed
to the build-info code. Rather than relying on os.path calls, it tries
to be generic and infer from the url of the request.

The problem is that we now can pass a search path like:

  foo//panda.txt

All our unit-tests have build-info patterns like *panda* and thus the
"foo//panda.txt" was okay because of the leading *. However, in
production people may use build-info's like panda* which no longer
match.

In one sense its a bug in 8f2768d, but really the root problem is that
the logic of BuildInfo.getInfoForFile was wrong. It was trying to do
fnmatch'ing based on full paths. However, build-info's are always for a
single directory, so its not needed and makes things more complex.

So the "fix" in this commit is really just the change to use:
 if fnmatch.fnmatch(self.fname, key):

To ensure we have test coverage, I updated the build-info/BUILD-INFO.txt
files so our unit-tests will fail w/o this fix. Specifically:

 license_protected_downloads.tests.test_views.ViewTests.test_unprotected_BUILD_INFO

Additionally, I further simplified the getInfoForFile method by removing
the block:

 if self.full_file_name == self.search_path:

This was a specialized case that is already handled by the fnmatch test.
To ensure this assumption I added a "raise RuntimeError" to the block
and saw the BuildInfoFileTests.test_apply_to_dir_auth_groups_field test
fail. Removing the block plus my "raise" hack got the tests working.

Change-Id: Ic4dcd1f99df2df20703198dec8ca06808c20f5cf

1 files changed, 1 insertions, 11 deletions

diff --git a/license_protected_downloads/buildinfo.py b/license_protected_downloads/buildinfo.py
index 8d423a3..42a789b 100644
--- a/license_protected_downloads/buildinfo.py
+++ b/license_protected_downloads/buildinfo.py
@@ -126,19 +126,9 @@ class BuildInfoBase(object):
                 # File name matches a key directly - don't need to iterate
                 # through each using fnmatch to implement globs.
                 return block[self.fname]
-
-            if self.full_file_name == self.search_path:
-                # Searching for directory match. This will only match the "*"
-                # glob.
-                if '*' in block:
-                    return block['*']
-                else:
-                    return [{}]
-
             for key in block:
                 if key != 'format-version':
-                    if fnmatch.fnmatch(self.full_file_name,
-                                       os.path.join(self.search_path, key)):
+                    if fnmatch.fnmatch(self.fname, key):
                         return block[key]
         return [{}]