aboutsummaryrefslogtreecommitdiff
path: root/drivers/staging/comedi/drivers/acl7225b.c
diff options
context:
space:
mode:
Diffstat (limited to 'drivers/staging/comedi/drivers/acl7225b.c')
-rw-r--r--drivers/staging/comedi/drivers/acl7225b.c141
1 files changed, 67 insertions, 74 deletions
diff --git a/drivers/staging/comedi/drivers/acl7225b.c b/drivers/staging/comedi/drivers/acl7225b.c
index 28c7fd3a96b..9e2c7aeea53 100644
--- a/drivers/staging/comedi/drivers/acl7225b.c
+++ b/drivers/staging/comedi/drivers/acl7225b.c
@@ -15,43 +15,59 @@ Devices: [Adlink] ACL-7225b (acl7225b), [ICP] P16R16DIO (p16r16dio)
#include <linux/ioport.h>
-#define ACL7225_SIZE 8 /* Requires 8 ioports, but only 4 are used */
-#define P16R16DIO_SIZE 4
#define ACL7225_RIO_LO 0 /* Relays input/output low byte (R0-R7) */
#define ACL7225_RIO_HI 1 /* Relays input/output high byte (R8-R15) */
#define ACL7225_DI_LO 2 /* Digital input low byte (DI0-DI7) */
#define ACL7225_DI_HI 3 /* Digital input high byte (DI8-DI15) */
-struct boardtype {
- const char *name; /* driver name */
- int io_range; /* len of I/O space */
+struct acl7225b_boardinfo {
+ const char *name;
+ int io_range;
};
-static int acl7225b_do_insn(struct comedi_device *dev,
- struct comedi_subdevice *s,
- struct comedi_insn *insn, unsigned int *data)
+static const struct acl7225b_boardinfo acl7225b_boards[] = {
+ {
+ .name = "acl7225b",
+ .io_range = 8, /* only 4 are used */
+ }, {
+ .name = "p16r16dio",
+ .io_range = 4,
+ },
+};
+
+static int acl7225b_do_insn_bits(struct comedi_device *dev,
+ struct comedi_subdevice *s,
+ struct comedi_insn *insn,
+ unsigned int *data)
{
- if (data[0]) {
- s->state &= ~data[0];
- s->state |= (data[0] & data[1]);
+ unsigned long reg = (unsigned long)s->private;
+ unsigned int mask = data[0];
+ unsigned int bits = data[1];
+
+ if (mask) {
+ s->state &= ~mask;
+ s->state |= (bits & mask);
+
+ if (mask & 0x00ff)
+ outb(s->state & 0xff, dev->iobase + reg);
+ if (mask & 0xff00)
+ outb((s->state >> 8), dev->iobase + reg + 1);
}
- if (data[0] & 0x00ff)
- outb(s->state & 0xff, dev->iobase + (unsigned long)s->private);
- if (data[0] & 0xff00)
- outb((s->state >> 8),
- dev->iobase + (unsigned long)s->private + 1);
data[1] = s->state;
return insn->n;
}
-static int acl7225b_di_insn(struct comedi_device *dev,
- struct comedi_subdevice *s,
- struct comedi_insn *insn, unsigned int *data)
+static int acl7225b_di_insn_bits(struct comedi_device *dev,
+ struct comedi_subdevice *s,
+ struct comedi_insn *insn,
+ unsigned int *data)
{
- data[1] = inb(dev->iobase + (unsigned long)s->private) |
- (inb(dev->iobase + (unsigned long)s->private + 1) << 8);
+ unsigned long reg = (unsigned long)s->private;
+
+ data[1] = inb(dev->iobase + reg) |
+ (inb(dev->iobase + reg + 1) << 8);
return insn->n;
}
@@ -59,23 +75,13 @@ static int acl7225b_di_insn(struct comedi_device *dev,
static int acl7225b_attach(struct comedi_device *dev,
struct comedi_devconfig *it)
{
- const struct boardtype *board = comedi_board(dev);
+ const struct acl7225b_boardinfo *board = comedi_board(dev);
struct comedi_subdevice *s;
- int iobase, iorange;
int ret;
- iobase = it->options[0];
- iorange = board->io_range;
- printk(KERN_INFO "comedi%d: acl7225b: board=%s 0x%04x\n", dev->minor,
- board->name, iobase);
- if (!request_region(iobase, iorange, "acl7225b")) {
- printk(KERN_ERR "comedi%d: request_region failed - I/O port conflict\n",
- dev->minor);
- return -EIO;
- }
- dev->board_name = board->name;
- dev->iobase = iobase;
- dev->irq = 0;
+ ret = comedi_request_region(dev, it->options[0], board->io_range);
+ if (ret)
+ return ret;
ret = comedi_alloc_subdevices(dev, 3);
if (ret)
@@ -83,61 +89,48 @@ static int acl7225b_attach(struct comedi_device *dev,
s = &dev->subdevices[0];
/* Relays outputs */
- s->type = COMEDI_SUBD_DO;
- s->subdev_flags = SDF_WRITABLE;
- s->maxdata = 1;
- s->n_chan = 16;
- s->insn_bits = acl7225b_do_insn;
- s->range_table = &range_digital;
- s->private = (void *)ACL7225_RIO_LO;
+ s->type = COMEDI_SUBD_DO;
+ s->subdev_flags = SDF_WRITABLE;
+ s->maxdata = 1;
+ s->n_chan = 16;
+ s->insn_bits = acl7225b_do_insn_bits;
+ s->range_table = &range_digital;
+ s->private = (void *)ACL7225_RIO_LO;
s = &dev->subdevices[1];
/* Relays status */
- s->type = COMEDI_SUBD_DI;
- s->subdev_flags = SDF_READABLE;
- s->maxdata = 1;
- s->n_chan = 16;
- s->insn_bits = acl7225b_di_insn;
- s->range_table = &range_digital;
- s->private = (void *)ACL7225_RIO_LO;
+ s->type = COMEDI_SUBD_DI;
+ s->subdev_flags = SDF_READABLE;
+ s->maxdata = 1;
+ s->n_chan = 16;
+ s->insn_bits = acl7225b_di_insn_bits;
+ s->range_table = &range_digital;
+ s->private = (void *)ACL7225_RIO_LO;
s = &dev->subdevices[2];
/* Isolated digital inputs */
- s->type = COMEDI_SUBD_DI;
- s->subdev_flags = SDF_READABLE;
- s->maxdata = 1;
- s->n_chan = 16;
- s->insn_bits = acl7225b_di_insn;
- s->range_table = &range_digital;
- s->private = (void *)ACL7225_DI_LO;
+ s->type = COMEDI_SUBD_DI;
+ s->subdev_flags = SDF_READABLE;
+ s->maxdata = 1;
+ s->n_chan = 16;
+ s->insn_bits = acl7225b_di_insn_bits;
+ s->range_table = &range_digital;
+ s->private = (void *)ACL7225_DI_LO;
return 0;
}
-static void acl7225b_detach(struct comedi_device *dev)
-{
- const struct boardtype *board = comedi_board(dev);
-
- if (dev->iobase)
- release_region(dev->iobase, board->io_range);
-}
-
-static const struct boardtype boardtypes[] = {
- { "acl7225b", ACL7225_SIZE, },
- { "p16r16dio", P16R16DIO_SIZE, },
-};
-
static struct comedi_driver acl7225b_driver = {
.driver_name = "acl7225b",
.module = THIS_MODULE,
.attach = acl7225b_attach,
- .detach = acl7225b_detach,
- .board_name = &boardtypes[0].name,
- .num_names = ARRAY_SIZE(boardtypes),
- .offset = sizeof(struct boardtype),
+ .detach = comedi_legacy_detach,
+ .board_name = &acl7225b_boards[0].name,
+ .num_names = ARRAY_SIZE(acl7225b_boards),
+ .offset = sizeof(struct acl7225b_boardinfo),
};
module_comedi_driver(acl7225b_driver);
+MODULE_DESCRIPTION("Comedi: NuDAQ ACL-7225B, 16 Relay & 16 Isolated DI Card");
MODULE_AUTHOR("Comedi http://www.comedi.org");
-MODULE_DESCRIPTION("Comedi low-level driver");
MODULE_LICENSE("GPL");