path: root/net
diff options
authorJulia Lawall <julia@diku.dk>2010-09-05 09:00:21 +0000
committerDavid S. Miller <davem@davemloft.net>2010-09-06 18:48:42 -0700
commit29af9309dba25077f711f5f975977714bc43a0c3 (patch)
tree5ff0faaa913d2ab8b431c272cab627b4f8778b59 /net
parente04c4dc87c4af296982ff44123e064d483e826c4 (diff)
net/9p/trans_fd.c: Fix unsigned return type
The function has an unsigned return type, but returns a negative constant to indicate an error condition. The result of calling the function is always stored in a variable of type (signed) int, and thus unsigned can be dropped from the return type. A sematic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @exists@ identifier f; constant C; @@ unsigned f(...) { <+... * return -C; ...+> } // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
1 files changed, 1 insertions, 1 deletions
diff --git a/net/9p/trans_fd.c b/net/9p/trans_fd.c
index c85109d809c..078eb162d9b 100644
--- a/net/9p/trans_fd.c
+++ b/net/9p/trans_fd.c
@@ -222,7 +222,7 @@ static void p9_conn_cancel(struct p9_conn *m, int err)
-static unsigned int
+static int
p9_fd_poll(struct p9_client *client, struct poll_table_struct *pt)
int ret, n;