aboutsummaryrefslogtreecommitdiff
path: root/arch/arm/mach-ux500/prcmu-fw.c
diff options
context:
space:
mode:
authorKumar Sanghvi <kumar.sanghvi@stericsson.com>2010-06-02 17:55:35 +0530
committerJohn Rigby <john.rigby@linaro.org>2010-09-02 22:45:32 -0600
commit79666f155b4a139d4917191914aafb18a0af2cf3 (patch)
tree8b197ff9b8e04355ac085f8bfb1827aea0ddee78 /arch/arm/mach-ux500/prcmu-fw.c
parent65b0e25654d63975ccf263ebde65ca2880fbe615 (diff)
downloadlinux-2.6.34-ux500-79666f155b4a139d4917191914aafb18a0af2cf3.tar.gz
u8500-prcmu: Fix coverity error prcmu code
Fixes the coverity error in ED portion of PRCMU FW init code ST-Ericsson ID: ER258727 Signed-off-by: Kumar Sanghvi <kumar.sanghvi@stericsson.com> Reviewed-on: http://gerrit.lud.stericsson.com/gerrit/729 Reviewed-by: Jonas ABERG <jonas.aberg@stericsson.com> Tested-by: Jonas ABERG <jonas.aberg@stericsson.com> Signed-off-by: Mian Yousaf Kaukab <mian.yousaf.kaukab@stericsson.com> Change-Id: Ifc3cb040b8b2df2a0960c50cf43d4ea9c866bc36 Reviewed-on: http://gerrit.lud.stericsson.com/gerrit/2392
Diffstat (limited to 'arch/arm/mach-ux500/prcmu-fw.c')
-rwxr-xr-xarch/arm/mach-ux500/prcmu-fw.c6
1 files changed, 5 insertions, 1 deletions
diff --git a/arch/arm/mach-ux500/prcmu-fw.c b/arch/arm/mach-ux500/prcmu-fw.c
index ed8274a5678..7117bd29f4e 100755
--- a/arch/arm/mach-ux500/prcmu-fw.c
+++ b/arch/arm/mach-ux500/prcmu-fw.c
@@ -23,6 +23,9 @@
#include "prcmu-fw_ed.h"
#include "prcmu-fw_v1.h"
+#define ED_FW_BOOT_STATE 0xFF
+#define ED_FW_T32_BOOT_STATE 0x2F
+
#define NAME "PRCMU"
#define PM_DEBUG 0
#define dbg_printk(format, arg...) (PM_DEBUG & 1) ? \
@@ -1580,7 +1583,8 @@ static int prcmu_fw_init(void)
if (u8500_is_earlydrop()) {
int i;
int status = prcmu_get_boot_status();
- if (status != 0xFF || status != 0x2F) {
+ if (!(status == ED_FW_BOOT_STATE ||
+ status == ED_FW_T32_BOOT_STATE)) {
printk("PRCMU Firmware not ready\n");
return -EIO;
}