aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJulien TINNES <julien@cr0.org>2009-08-27 15:26:58 +0200
committerLinus Torvalds <torvalds@linux-foundation.org>2009-08-27 12:23:43 -0700
commit788d908f2879a17e5f80924f3da2e23f1034482d (patch)
tree890ada4f22e9ce5d64a121efc1ca63390d6b2100
parent9886e836a6a5dbd273dc55b17e713f0a188d137f (diff)
downloadlinux-2.6.34-ux500-788d908f2879a17e5f80924f3da2e23f1034482d.tar.gz
ipv4: make ip_append_data() handle NULL routing table
Add a check in ip_append_data() for NULL *rtp to prevent future bugs in callers from being exploitable. Signed-off-by: Julien Tinnes <julien@cr0.org> Signed-off-by: Tavis Ormandy <taviso@sdf.lonestar.org> Acked-by: David S. Miller <davem@davemloft.net> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r--net/ipv4/ip_output.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_output.c
index 7d082105472..7ffcd96fe59 100644
--- a/net/ipv4/ip_output.c
+++ b/net/ipv4/ip_output.c
@@ -813,6 +813,8 @@ int ip_append_data(struct sock *sk,
inet->cork.addr = ipc->addr;
}
rt = *rtp;
+ if (unlikely(!rt))
+ return -EFAULT;
/*
* We steal reference to this route, caller should not release it
*/