From fff3e5ade4455a4b42a19c95dd7a167a3cb7956a Mon Sep 17 00:00:00 2001 From: Milton Miller Date: Thu, 14 Apr 2011 10:30:08 -0500 Subject: fs: synchronize_rcu when unregister_filesystem success not failure While checking unregister_filesystem for saftey vs extra calls for "ext4: register ext2 and ext3 alias after ext4" I realized that the synchronize_rcu() was called on the error path but not on the success path. Cc: stable (2.6.38) Signed-off-by: Milton Miller [ This probably won't really make a difference since commit d863b50ab013 ("vfs: call rcu_barrier after ->kill_sb()"), but it's the right thing to do. - Linus ] Signed-off-by: Linus Torvalds --- fs/filesystems.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/filesystems.c b/fs/filesystems.c index 751d6b255a1..0845f84f2a5 100644 --- a/fs/filesystems.c +++ b/fs/filesystems.c @@ -110,14 +110,13 @@ int unregister_filesystem(struct file_system_type * fs) *tmp = fs->next; fs->next = NULL; write_unlock(&file_systems_lock); + synchronize_rcu(); return 0; } tmp = &(*tmp)->next; } write_unlock(&file_systems_lock); - synchronize_rcu(); - return -EINVAL; } -- cgit v1.2.3