aboutsummaryrefslogtreecommitdiff
path: root/kernel
diff options
context:
space:
mode:
authorRusty Russell <rusty@rustcorp.com.au>2008-10-22 10:00:23 -0500
committerRusty Russell <rusty@rustcorp.com.au>2008-10-22 10:00:23 +1100
commit67e67ceaac5bf55dbdceb704ff2d763d438b5373 (patch)
tree59523536661c93dce7a02557ca6ac5827a7bf75f /kernel
parent9b473de87209fa86eb421b23386693b461612f30 (diff)
downloadlinux-linaro-67e67ceaac5bf55dbdceb704ff2d763d438b5373.tar.gz
core_param() for genuinely core kernel parameters
There are a lot of one-liner uses of __setup() in the kernel: they're cumbersome and not queryable (definitely not settable) via /sys. Yet it's ugly to simplify them to module_param(), because by default that inserts a prefix of the module name (usually filename). So, introduce a "core_param". The parameter gets no prefix, but appears in /sys/module/kernel/parameters/ (if non-zero perms arg). I thought about using the name "core", but that's more common than "kernel". And if you create a module called "kernel", you will die a horrible death. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Diffstat (limited to 'kernel')
-rw-r--r--kernel/params.c14
1 files changed, 7 insertions, 7 deletions
diff --git a/kernel/params.c b/kernel/params.c
index f27c992a462..b077f1b045d 100644
--- a/kernel/params.c
+++ b/kernel/params.c
@@ -637,14 +637,14 @@ static void __init param_sysfs_builtin(void)
dot = strchr(kp->name, '.');
if (!dot) {
- DEBUGP("couldn't find period in first %d characters "
- "of %s\n", MODULE_NAME_LEN, kp->name);
- continue;
+ /* This happens for core_param() */
+ strcpy(modname, "kernel");
+ name_len = 0;
+ } else {
+ name_len = dot - kp->name + 1;
+ strlcpy(modname, kp->name, name_len);
}
- name_len = dot - kp->name;
- strncpy(modname, kp->name, name_len);
- modname[name_len] = '\0';
- kernel_add_sysfs_param(modname, kp, name_len+1);
+ kernel_add_sysfs_param(modname, kp, name_len);
}
}