path: root/arch/sparc/prom
diff options
authorNicolas Palix <npalix@diku.dk>2008-12-03 21:10:57 -0800
committerDavid S. Miller <davem@davemloft.net>2008-12-04 09:17:22 -0800
commitc2e27c359ab76fecbbd292dbfc0bcfa8399afdd9 (patch)
treed5edacb837ce1d1bc35aa2827e00b314e679f400 /arch/sparc/prom
parenta8c601ca21e790f6a9d996bb0bf31f7496eb9509 (diff)
sparc: Add missing of_node_put
of_node_put is needed before discarding a value received from of_find_node_by_name, eg in error handling code or when the device node is no longer used. The semantic match that catches the bug is as follows: (http://www.emn.fr/x-info/coccinelle/) // <smpl> @r exists@ local idexpression struct device_node *n; position p1, p2; struct device_node *n1; statement S; identifier f; expression E; expression *ptr != NULL; @@ n@p1 = of_find_node_by_name(...) ... if (!n) S ... when != of_node_put(n) when != n1 = f(n,...) when != E = n when any when strict ( return \(0\|<+...n...+>\|ptr\); | return@p2 ...; | of_node_put(n); | n1 = f(n,...) | E = n ) @script:python@ p1 << r.p1; p2 << r.p2; @@ print "* file: %s of_find_node_by_name %s return %s" % (p1[0].file,p1[0].line,p2[0].line) // </smpl> Signed-off-by: Nicolas Palix <npalix@diku.dk> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'arch/sparc/prom')
0 files changed, 0 insertions, 0 deletions