aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJohn Youn <John.Youn@synopsys.com>2010-08-09 13:56:11 -0700
committerGreg Kroah-Hartman <gregkh@suse.de>2010-08-26 16:46:25 -0700
commitba6da120819f5ffc44cbb5a66fc70f1e9f2f858e (patch)
tree7e31c3cfe05e1af421912e54c24e6dd066f9aaa3
parente5af095003749e3f9bc1ff3db77ef7c91dc79459 (diff)
downloadlinux-linaro-ba6da120819f5ffc44cbb5a66fc70f1e9f2f858e.tar.gz
USB: xhci: Remove buggy assignment in next_trb()
commit a1669b2c64a9c8b031e0ac5cbf2692337a577f7c upstream. The code to increment the TRB pointer has a slight ambiguity that could lead to a bug on different compilers. The ANSI C specification does not specify the precedence of the assignment operator over the postfix operator. gcc 4.4 produced the correct code (increment the pointer and assign the value), but a MIPS compiler that one of John's clients used assigned the old (unincremented) value. Remove the unnecessary assignment to make all compilers produce the correct assembly. Signed-off-by: John Youn <johnyoun@synopsys.com> Signed-off-by: Sarah Sharp <sarah.a.sharp@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-rw-r--r--drivers/usb/host/xhci-ring.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
index bfc99a93945..221f99930dc 100644
--- a/drivers/usb/host/xhci-ring.c
+++ b/drivers/usb/host/xhci-ring.c
@@ -131,7 +131,7 @@ static void next_trb(struct xhci_hcd *xhci,
*seg = (*seg)->next;
*trb = ((*seg)->trbs);
} else {
- *trb = (*trb)++;
+ (*trb)++;
}
}