path: root/arch/x86/include
diff options
authorDon Zickus <dzickus@redhat.com>2011-02-07 23:25:00 -0500
committerIngo Molnar <mingo@elte.hu>2011-02-28 16:22:18 +0100
commit299c56966a72b9109d47c71a6db52097098703dd (patch)
treee2cbb4a2f38a6002cfb53112fc8e04e959585939 /arch/x86/include
parent493f3358cb289ccf716c5a14fa5bb52ab75943e5 (diff)
x86: Use u32 instead of long to set reset vector back to 0
A customer of ours, complained that when setting the reset vector back to 0, it trashed other data and hung their box. They noticed when only 4 bytes were set to 0 instead of 8, everything worked correctly. Mathew pointed out: | | We're supposed to be resetting trampoline_phys_low and | trampoline_phys_high here, which are two 16-bit values. | Writing 64 bits is definitely going to overwrite space | that we're not supposed to be touching. | So limit the area modified to u32. Signed-off-by: Don Zickus <dzickus@redhat.com> Acked-by: Matthew Garrett <mjg@redhat.com> Cc: <stable@kernel.org> LKML-Reference: <1297139100-424-1-git-send-email-dzickus@redhat.com> Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'arch/x86/include')
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/x86/include/asm/smpboot_hooks.h b/arch/x86/include/asm/smpboot_hooks.h
index 6c22bf353f2..725b7783199 100644
--- a/arch/x86/include/asm/smpboot_hooks.h
+++ b/arch/x86/include/asm/smpboot_hooks.h
@@ -34,7 +34,7 @@ static inline void smpboot_restore_warm_reset_vector(void)
CMOS_WRITE(0, 0xf);
- *((volatile long *)phys_to_virt(apic->trampoline_phys_low)) = 0;
+ *((volatile u32 *)phys_to_virt(apic->trampoline_phys_low)) = 0;
static inline void __init smpboot_setup_io_apic(void)