aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPetr Tesarik <ptesarik@suse.cz>2008-09-03 13:31:42 +0200
committerIngo Molnar <mingo@elte.hu>2008-09-05 17:53:16 +0200
commit4ab4ba32aa16b012cb0faabf1a27952508fe67f2 (patch)
treef14fc366eb714e996bec4d10ef9f8e9c674cf7aa
parent28c3cfd5fb998bd3683bebeebbba38baa2101cad (diff)
downloadlinux-linaro-android-4ab4ba32aa16b012cb0faabf1a27952508fe67f2.tar.gz
x86, tracehook: clean up implementation of syscall_get_error()
The x86-tracehook code now contains this line in syscall_get_error(): return error >= -4095L ? error : 0; Hard-wiring a constant is not nice. Let's use the IS_ERR_VALUE macro from linux/err.h instead. Signed-off-by: Petr Tesarik <ptesarik@suse.cz> Cc: utrace-devel@redhat.com Acked-by: Roland McGrath <roland@redhat.com> Signed-off-by: Ingo Molnar <mingo@elte.hu>
-rw-r--r--include/asm-x86/syscall.h3
1 files changed, 2 insertions, 1 deletions
diff --git a/include/asm-x86/syscall.h b/include/asm-x86/syscall.h
index 6f293892895..04c47dc5597 100644
--- a/include/asm-x86/syscall.h
+++ b/include/asm-x86/syscall.h
@@ -14,6 +14,7 @@
#define _ASM_SYSCALL_H 1
#include <linux/sched.h>
+#include <linux/err.h>
static inline long syscall_get_nr(struct task_struct *task,
struct pt_regs *regs)
@@ -47,7 +48,7 @@ static inline long syscall_get_error(struct task_struct *task,
*/
error = (long) (int) error;
#endif
- return error >= -4095L ? error : 0;
+ return IS_ERR_VALUE(error) ? error : 0;
}
static inline long syscall_get_return_value(struct task_struct *task,