diff options
| author | Rui Ueyama <ruiu@google.com> | 2019-01-23 02:03:26 +0000 |
|---|---|---|
| committer | Rui Ueyama <ruiu@google.com> | 2019-01-23 02:03:26 +0000 |
| commit | f6abb4b500f4f30f8ced624c7ff53e192f4c38e4 (patch) | |
| tree | 79fd4e13eed90553b1d4fe3dd8ce1dbdd1bbcdbb | |
| parent | e67de3fa5ebbf23fd0685e1c04e3e424f1d50986 (diff) | |
MemoryBlock: Do not automatically extend a given size to a multiple of page size.
Previously, MemoryBlock automatically extends a requested buffer size to a
multiple of page size because (I believe) doing it was thought to be harmless
and with that you could get more memory (on average 2KiB on 4KiB-page systems)
"for free".
That programming interface turned out to be error-prone. If you request N
bytes, you usually expect that a resulting object returns N for `size()`.
That's not the case for MemoryBlock.
Looks like there is only one place where we take the advantage of
allocating more memory than the requested size. So, with this patch, I
simply removed the automatic size expansion feature from MemoryBlock
and do it on the caller side when needed. MemoryBlock now always
returns a buffer whose size is equal to the requested size.
Differential Revision: https://reviews.llvm.org/D56941
git-svn-id: https://llvm.org/svn/llvm-project/lld/trunk@351916 91177308-0d34-0410-b5e6-96231b3b80d8
| -rw-r--r-- | test/ELF/stdout.s | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/test/ELF/stdout.s b/test/ELF/stdout.s index 331167e3f..6c41436bc 100644 --- a/test/ELF/stdout.s +++ b/test/ELF/stdout.s @@ -1,12 +1,15 @@ # REQUIRES: x86 # RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t.o -# RUN: ld.lld %t.o -o - > %t -# RUN: llvm-objdump -d %t | FileCheck %s +# RUN: ld.lld %t.o -o - > %t1 +# RUN: llvm-objdump -d %t1 | FileCheck %s # CHECK: 0000000000201000 _start: # CHECK: 201000: 90 nop +# RUN: ld.lld %t.o -o %t2 +# RUN: diff %t1 %t2 + .globl _start _start: nop |