aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorjakub <jakub@138bc75d-0d04-0410-961f-82ee72b054a4>2019-01-21 22:33:52 +0000
committerjakub <jakub@138bc75d-0d04-0410-961f-82ee72b054a4>2019-01-21 22:33:52 +0000
commit77fe9474a57d5947867ae55b14881133e0636c74 (patch)
tree5bcf9aac2ab5fb87ec37838b8be6f37402aca0c7
parentd2019c0387aede63b52f6be465a8af0de5d67f53 (diff)
PR c++/88949
* optimize.c (cxx_copy_decl): New function. (clone_body): Use it instead of copy_decl_no_change. * g++.dg/gomp/pr88949.C: New test. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@268127 138bc75d-0d04-0410-961f-82ee72b054a4
-rw-r--r--gcc/cp/ChangeLog4
-rw-r--r--gcc/cp/optimize.c21
-rw-r--r--gcc/testsuite/ChangeLog5
-rw-r--r--gcc/testsuite/g++.dg/gomp/pr88949.C23
4 files changed, 52 insertions, 1 deletions
diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog
index e5ce94c75e8..111782aeaba 100644
--- a/gcc/cp/ChangeLog
+++ b/gcc/cp/ChangeLog
@@ -1,5 +1,9 @@
2019-01-21 Jakub Jelinek <jakub@redhat.com>
+ PR c++/88949
+ * optimize.c (cxx_copy_decl): New function.
+ (clone_body): Use it instead of copy_decl_no_change.
+
PR sanitizer/88901
* typeck.c (cp_build_binary_op): Don't instrument
SANITIZE_POINTER_COMPARE if processing_template_decl.
diff --git a/gcc/cp/optimize.c b/gcc/cp/optimize.c
index 40d0dcc3995..7b6edfc0e49 100644
--- a/gcc/cp/optimize.c
+++ b/gcc/cp/optimize.c
@@ -61,6 +61,25 @@ update_cloned_parm (tree parm, tree cloned_parm, bool first)
DECL_GIMPLE_REG_P (cloned_parm) = DECL_GIMPLE_REG_P (parm);
}
+/* Like copy_decl_no_change, but handle DECL_OMP_PRIVATIZED_MEMBER
+ properly. */
+
+static tree
+cxx_copy_decl (tree decl, copy_body_data *id)
+{
+ tree copy = copy_decl_no_change (decl, id);
+ if (VAR_P (decl)
+ && DECL_HAS_VALUE_EXPR_P (decl)
+ && DECL_ARTIFICIAL (decl)
+ && DECL_LANG_SPECIFIC (decl)
+ && DECL_OMP_PRIVATIZED_MEMBER (decl))
+ {
+ tree expr = DECL_VALUE_EXPR (copy);
+ walk_tree (&expr, copy_tree_body_r, id, NULL);
+ SET_DECL_VALUE_EXPR (copy, expr);
+ }
+ return copy;
+}
/* FN is a function in High GIMPLE form that has a complete body and no
CFG. CLONE is a function whose body is to be set to a copy of FN,
@@ -80,7 +99,7 @@ clone_body (tree clone, tree fn, void *arg_map)
id.src_cfun = DECL_STRUCT_FUNCTION (fn);
id.decl_map = static_cast<hash_map<tree, tree> *> (arg_map);
- id.copy_decl = copy_decl_no_change;
+ id.copy_decl = cxx_copy_decl;
id.transform_call_graph_edges = CB_CGE_DUPLICATE;
id.transform_new_cfg = true;
id.transform_return_to_modify = false;
diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index ce462ac79d9..86910c2b4f7 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2019-01-21 Jakub Jelinek <jakub@redhat.com>
+
+ PR c++/88949
+ * g++.dg/gomp/pr88949.C: New test.
+
2019-01-21 Manfred Schwarb <manfred99@gmx.ch>
* class_66.f90: Fix a dg directive.
diff --git a/gcc/testsuite/g++.dg/gomp/pr88949.C b/gcc/testsuite/g++.dg/gomp/pr88949.C
new file mode 100644
index 00000000000..04d2415971a
--- /dev/null
+++ b/gcc/testsuite/g++.dg/gomp/pr88949.C
@@ -0,0 +1,23 @@
+// PR c++/88949
+// { dg-do compile }
+
+struct A {
+ int a;
+ A (int x) : a (x) {
+#pragma omp parallel firstprivate (a)
+ --a;
+ }
+ void foo () {
+#pragma omp parallel firstprivate (a)
+ --a;
+ }
+};
+
+int c;
+
+int
+main ()
+{
+ A d(c);
+ d.foo ();
+}