summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndrew Morton <akpm@linux-foundation.org>2020-05-30 14:51:16 +1000
committerStephen Rothwell <sfr@canb.auug.org.au>2020-06-02 19:28:39 +1000
commitc93cea13edc6278ddebcce7bffef6bf5d613645e (patch)
treedfd309251bd6e54bd9e762e49f17e66b3c178fcd
parentd4777e3ebf3d85db946373f3ebc84f409b60466f (diff)
downloadlinux-c93cea13edc6278ddebcce7bffef6bf5d613645e.tar.gz
x86-use-non-set_fs-based-maccess-routines-x86-use-non-set_fs-based-maccess-routines
WARNING: Macros with flow control statements should be avoided #30: FILE: arch/x86/include/asm/uaccess.h:528: +#define __get_kernel_nofault(dst, src, type, err_label) \ +do { \ + int __kr_err; \ + \ + __get_user_size(*((type *)dst), (__force type __user *)src, \ + sizeof(type), __kr_err); \ + if (unlikely(__kr_err)) \ + goto err_label; \ +} while (0) ERROR: code indent should use tabs where possible #32: FILE: arch/x86/include/asm/uaccess.h:530: + int __kr_err;^I^I^I^I^I^I^I\$ WARNING: please, no spaces at the start of a line #32: FILE: arch/x86/include/asm/uaccess.h:530: + int __kr_err;^I^I^I^I^I^I^I\$ ERROR: code indent should use tabs where possible #36: FILE: arch/x86/include/asm/uaccess.h:534: + if (unlikely(__kr_err))^I^I^I^I^I^I\$ WARNING: please, no spaces at the start of a line #36: FILE: arch/x86/include/asm/uaccess.h:534: + if (unlikely(__kr_err))^I^I^I^I^I^I\$ total: 2 errors, 3 warnings, 21 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. NOTE: Whitespace errors detected. You may wish to use scripts/cleanpatch or scripts/cleanfile ./patches/x86-use-non-set_fs-based-maccess-routines.patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Christoph Hellwig <hch@lst.de> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
-rw-r--r--arch/x86/include/asm/uaccess.h4
1 files changed, 2 insertions, 2 deletions
diff --git a/arch/x86/include/asm/uaccess.h b/arch/x86/include/asm/uaccess.h
index b3e0a56ae961..35b23b0311f5 100644
--- a/arch/x86/include/asm/uaccess.h
+++ b/arch/x86/include/asm/uaccess.h
@@ -527,11 +527,11 @@ do { \
#define __get_kernel_nofault(dst, src, type, err_label) \
do { \
- int __kr_err; \
+ int __kr_err; \
\
__get_user_size(*((type *)dst), (__force type __user *)src, \
sizeof(type), __kr_err); \
- if (unlikely(__kr_err)) \
+ if (unlikely(__kr_err)) \
goto err_label; \
} while (0)