diff options
| author | Thiago Jung Bauermann <thiago.bauermann@linaro.org> | 2023-09-28 12:57:51 -0300 |
|---|---|---|
| committer | Thiago Jung Bauermann <thiago.bauermann@linaro.org> | 2023-10-04 11:23:35 -0300 |
| commit | b6a7eb1e0c828dfc16e66a22db925a9fa6ce7faf (patch) | |
| tree | 4f241d32fec2674b2a750f368e4aca1080f3cc7b | |
| parent | 1956e915825a3e1c1ec99ee032f7c8fe51027cb7 (diff) | |
make.sh: Run GDB testsuite with read1 library
GDB has a test debugging library which is ld-preloaded into expect and
causes it to read one byte at a time from the tested tool. This allows
finding test races (see gdb/testsuite/README), and also makes the testsuite
run more deterministically.
Some testcases are buggy and have additional failures when running under
read1. In particular, gdb.linespec/cpcompletion.exp has 422 FAILs and
gdb.mi/mi2-var-child.exp has 425 FAILs. A couple of tests in gdb.mi are
still as flaky (and verbose) as before though.
The testsuite unexpected failures go from 56 to 1411. Still, the increased
stability of the test results makes this change worth it.
With this change, the check_gdb step goes from about 1h to 5h30m. I'll
explore enabling running the tests in parallel to compensate the increase
in run time.
Change-Id: I1ab812a6ba2492778bca5c87e4480499f76ad6cf
| -rw-r--r-- | lib/make.sh | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/lib/make.sh b/lib/make.sh index bf1c414a..6422ab5a 100644 --- a/lib/make.sh +++ b/lib/make.sh @@ -883,7 +883,10 @@ tool_to_dirs() gcc) dirs="/" ;; - gdb|glibc) + gdb) + dirs="/gdb" + ;; + glibc) case "$tool" in none) ;; *) @@ -935,7 +938,7 @@ tool_to_check() esac ;; gdb) - check="check-gdb" + check="check-read1" ;; glibc) check="check" |