diff options
| author | Linus Walleij <linus.walleij@linaro.org> | 2023-10-04 11:02:05 +0200 |
|---|---|---|
| committer | Linus Walleij <linus.walleij@linaro.org> | 2023-10-06 23:04:21 +0200 |
| commit | 0a9a2dc4d137fa9a5fbf89a566ccf6e781b9338c (patch) | |
| tree | d72fe8baad30b0722fc501f753b14f496d738a20 | |
| parent | 5a4aba152f9efdca57c18f28ff2448d23aba8e4d (diff) | |
pinctrl: realtek: Fix some NULL dereference warningssent/fix-realtek-warnings-v1
Just inspecting the code doesn't convince me that this is a real
issue, but the tools complain that it is so I will just handle it.
Cc: Tzuyi Chang <tychang@realtek.com>
Link: https://lore.kernel.org/oe-kbuild-all/202309270234.aJGlDE0P-lkp@intel.com/
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
| -rw-r--r-- | drivers/pinctrl/realtek/pinctrl-rtd.c | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/drivers/pinctrl/realtek/pinctrl-rtd.c b/drivers/pinctrl/realtek/pinctrl-rtd.c index bafe27face80..fc27e4f61be1 100644 --- a/drivers/pinctrl/realtek/pinctrl-rtd.c +++ b/drivers/pinctrl/realtek/pinctrl-rtd.c @@ -165,7 +165,10 @@ static int rtd_pinctrl_set_one_mux(struct pinctrl_dev *pcdev, return 0; if (!mux->functions) { - dev_err(pcdev->dev, "No functions available for pin %s\n", mux->name); + if (!mux->name) + dev_err(pcdev->dev, "NULL pin has no functions\n"); + else + dev_err(pcdev->dev, "No functions available for pin %s\n", mux->name); return -ENOTSUPP; } @@ -177,6 +180,11 @@ static int rtd_pinctrl_set_one_mux(struct pinctrl_dev *pcdev, return ret; } + if (!mux->name) { + dev_err(pcdev->dev, "NULL pin provided for function %s\n", func_name); + return -EINVAL; + } + dev_err(pcdev->dev, "No function %s available for pin %s\n", func_name, mux->name); return -EINVAL; |