path: root/virt
diff options
authorEric W. Biederman <ebiederm@xmission.com>2018-08-15 21:20:46 -0500
committerEric W. Biederman <ebiederm@xmission.com>2018-08-15 23:03:20 -0500
commit84fe4cc09abc1a5ef3a282db3ed10f4d3f1e6a0b (patch)
tree8bca92f3c76e42aee803946cd458a0c081862884 /virt
parentc3ad2c3b02e953ead2b8d52a0c9e70312930c3d0 (diff)
signal: Don't send signals to tasks that don't exist
Recently syzbot reported crashes in send_sigio_to_task and send_sigurg_to_task in linux-next. Despite finding a reproducer syzbot apparently did not bisected this or otherwise track down the offending commit in linux-next. I happened to see this report and examined the code because I had recently changed these functions as part of making PIDTYPE_TGID a real pid type so that fork would does not need to restart when receiving a signal. By examination I see that I spotted a bug in the code that could explain the reported crashes. When I took Oleg's suggestion and optimized send_sigurg and send_sigio to only send to a single task when type is PIDTYPE_PID or PIDTYPE_TGID I failed to handle pids that no longer point to tasks. The macro do_each_pid_task simply iterates for zero iterations. With pid_task an explicit NULL test is needed. Update the code to include the missing NULL test. Fixes: 019191342fec ("signal: Use PIDTYPE_TGID to clearly store where file signals will be sent") Reported-by: syzkaller-bugs@googlegroups.com Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Diffstat (limited to 'virt')
0 files changed, 0 insertions, 0 deletions