path: root/sound
diff options
authorTakashi Iwai <tiwai@suse.de>2017-02-07 09:32:30 +0100
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2017-02-14 15:25:41 -0800
commit34f840fc0d8918fc015ee8bd8a2e1a457c7094e2 (patch)
tree373df4a8a52f70fd00c78bc4b9b19b1372af0b36 /sound
parent23b1595b977c9ce4fe498363c636a555c216a9e2 (diff)
Revert "ALSA: line6: Only determine control port properties if needed"
commit f3d83317a69e7d658e7c83e24f8b31ac533c39e3 upstream. This reverts commit f6a0dd107ad0c8b59d1c9735eea4b8cb9f460949. The commit caused a regression on LINE6 Transport that has no control caps. Although reverting the commit may result back in a spurious error message for some device again, it's the simplest regression fix, hence it's taken as is at first. The further code fix will follow later. Fixes: f6a0dd107ad0 ("ALSA: line6: Only determine control port properties if needed") Reported-by: Igor Zinovev <zinigor@gmail.com> Signed-off-by: Takashi Iwai <tiwai@suse.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'sound')
1 files changed, 2 insertions, 1 deletions
diff --git a/sound/usb/line6/driver.c b/sound/usb/line6/driver.c
index 90009c0b3a92..ab3c280a23d1 100644
--- a/sound/usb/line6/driver.c
+++ b/sound/usb/line6/driver.c
@@ -754,8 +754,9 @@ int line6_probe(struct usb_interface *interface,
goto error;
+ line6_get_interval(line6);
if (properties->capabilities & LINE6_CAP_CONTROL) {
- line6_get_interval(line6);
ret = line6_init_cap_control(line6);
if (ret < 0)
goto error;