path: root/sound
diff options
authorTakashi Sakamoto <o-takashi@sakamocchi.jp>2017-04-14 12:43:01 +0900
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2017-05-03 08:36:37 -0700
commit26b9b1565baff9be66a3aff29e08a1251f5c1bb6 (patch)
treef135537664d6d8e78c5bd9768d6cc2822b97e79c /sound
parent827faa2e4ef715a165449475d001606044c3eed2 (diff)
ALSA: firewire-lib: fix inappropriate assignment between signed/unsigned type
commit dfb00a56935186171abb5280b3407c3f910011f1 upstream. An abstraction of asynchronous transaction for transmission of MIDI messages was introduced in Linux v4.4. Each driver can utilize this abstraction to transfer MIDI messages via fixed-length payload of transaction to a certain unit address. Filling payload of the transaction is done by callback. In this callback, each driver can return negative error code, however current implementation assigns the return value to unsigned variable. This commit changes type of the variable to fix the bug. Reported-by: Julia Lawall <Julia.Lawall@lip6.fr> Fixes: 585d7cba5e1f ("ALSA: firewire-lib: add helper functions for asynchronous transactions to transfer MIDI messages") Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp> Signed-off-by: Takashi Iwai <tiwai@suse.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'sound')
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/firewire/lib.h b/sound/firewire/lib.h
index f6769312ebfc..c3768cd494a5 100644
--- a/sound/firewire/lib.h
+++ b/sound/firewire/lib.h
@@ -45,7 +45,7 @@ struct snd_fw_async_midi_port {
struct snd_rawmidi_substream *substream;
snd_fw_async_midi_port_fill fill;
- unsigned int consume_bytes;
+ int consume_bytes;
int snd_fw_async_midi_port_init(struct snd_fw_async_midi_port *port,