aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSrinivas Kandagatla <srinivas.kandagatla@linaro.org>2019-03-11 13:11:16 +0000
committerSrinivas Kandagatla <srinivas.kandagatla@linaro.org>2019-03-28 16:16:28 +0000
commitd95267be88feb2b8e688fadb1f943453234aaf91 (patch)
tree8d662aa23f29e586aae2b64e6d0dbf737a8e2dde
parent98b99ef035df11c854e6e2ae2b46e24f3b0c43a2 (diff)
regmap: regmap-irq: fix getting type default valueswip/soundwire
Checking for value of type default value just after allocating will allways be zero and the type register default values will never be read, so fix this. Without this patch setting irq type will be silently ingnored. Patch "regmap: regmap-irq: Remove default irq type setting from core" did remove the default mask but it forgot to remove the check before reading the default type register. Fixes: 84267d1b18ab ("regmap: regmap-irq: Remove default irq type setting from core") Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
-rw-r--r--drivers/base/regmap/regmap-irq.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/base/regmap/regmap-irq.c b/drivers/base/regmap/regmap-irq.c
index 5059748afd4c5..02eb756461415 100644
--- a/drivers/base/regmap/regmap-irq.c
+++ b/drivers/base/regmap/regmap-irq.c
@@ -761,9 +761,6 @@ int regmap_add_irq_chip(struct regmap *map, int irq, int irq_flags,
if (chip->num_type_reg && !chip->type_in_mask) {
for (i = 0; i < chip->num_type_reg; ++i) {
- if (!d->type_buf_def[i])
- continue;
-
reg = chip->type_base +
(i * map->reg_stride * d->type_reg_stride);