diff options
| author | Stacey Gammon <gammon@elastic.co> | 2017-07-24 09:01:37 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-07-24 09:01:37 -0400 |
| commit | 2f233030bc6b47b4104a2afcbade35b6cd9613fc (patch) | |
| tree | 0bdbb568b3e79d37c0db0f56b64e6f257ede35af | |
| parent | 2043cf0e0ad0b4a3fc0dac138f3be28bb936aa8a (diff) | |
Children of buttons won't capture hover events in firefox (#13015)
* Children of buttons won't capture hover events in firefox
Fixes https://github.com/elastic/kibana/issues/12987
* Make full screen div accessible
* Remove nested aria labels
| -rw-r--r-- | src/core_plugins/kibana/public/dashboard/dashboard.html | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/src/core_plugins/kibana/public/dashboard/dashboard.html b/src/core_plugins/kibana/public/dashboard/dashboard.html index 184223bb2..adf2797a6 100644 --- a/src/core_plugins/kibana/public/dashboard/dashboard.html +++ b/src/core_plugins/kibana/public/dashboard/dashboard.html @@ -1,16 +1,18 @@ <dashboard-app class="app-container dashboard-container"> <div class="fullScreenModePlaceholder"> - <button + <div + aria-label="Exit full screen mode" + kbn-accessible-click ng-if="fullScreenMode" class="exitFullScreenMode" ng-click="exitFullScreenMode()" > - <span aria-hidden="true" class="exitFullScreenModeLogo"></span> + <span class="exitFullScreenModeLogo"></span> <span class="exitFullScreenModeText"> Exit full screen - <span aria-hidden="true" class="kuiIcon fa fa-angle-left"></span> + <span class="kuiIcon fa fa-angle-left"></span> </span> - </button> + </div> </div> <!-- Local nav. --> <kbn-top-nav name="dashboard" config="topNavMenu"> |