diff options
| author | Avi Kivity <avi@qumranet.com> | 2007-07-23 18:33:14 +0300 |
|---|---|---|
| committer | Avi Kivity <avi@qumranet.com> | 2007-07-23 18:33:14 +0300 |
| commit | b41e5014dd8712e8de2b656617f7a7a158cd992a (patch) | |
| tree | c4dbd991cf4ae0deced60bd634ba834059e6fd37 | |
| parent | 769c5c41c296e64444ee10b8f9d4aa2973a50883 (diff) | |
Revert "KVM: Avoid useless memory write when possible"kvm-33
This reverts commit 8a1449563b3e5ede56b28cc977c8da22a17cdf51. While it
does save useless updates, it (probably) defeats the fork detector, causing
a massive performance loss.
Signed-off-by: Avi Kivity <avi@qumranet.com>
| -rw-r--r-- | drivers/kvm/kvm_main.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/kvm/kvm_main.c b/drivers/kvm/kvm_main.c index 7c9bd72f74d5..6e11871f5319 100644 --- a/drivers/kvm/kvm_main.c +++ b/drivers/kvm/kvm_main.c @@ -1085,10 +1085,8 @@ static int emulator_write_phys(struct kvm_vcpu *vcpu, gpa_t gpa, return 0; mark_page_dirty(vcpu->kvm, gpa >> PAGE_SHIFT); virt = kmap_atomic(page, KM_USER0); - if (memcmp(virt + offset_in_page(gpa), val, bytes)) { - kvm_mmu_pte_write(vcpu, gpa, virt + offset, val, bytes); - memcpy(virt + offset_in_page(gpa), val, bytes); - } + kvm_mmu_pte_write(vcpu, gpa, virt + offset, val, bytes); + memcpy(virt + offset_in_page(gpa), val, bytes); kunmap_atomic(virt, KM_USER0); return 1; } |