path: root/mm/filemap.c
diff options
authoranfei zhou <>2010-02-02 13:44:02 -0800
committerLinus Torvalds <>2010-02-02 18:11:21 -0800
commit931e80e4b3263db75c8e34f078d22f11bbabd3a3 (patch)
tree47c735f039d2c8623a1fc4d20333a9899ac8e99c /mm/filemap.c
parentbc173f7092c76a7967f135c2b3a54052ad99733b (diff)
mm: flush dcache before writing into page to avoid alias
The cache alias problem will happen if the changes of user shared mapping is not flushed before copying, then user and kernel mapping may be mapped into two different cache line, it is impossible to guarantee the coherence after iov_iter_copy_from_user_atomic. So the right steps should be: flush_dcache_page(page); kmap_atomic(page); write to page; kunmap_atomic(page); flush_dcache_page(page); More precisely, we might create two new APIs flush_dcache_user_page and flush_dcache_kern_page to replace the two flush_dcache_page accordingly. Here is a snippet tested on omap2430 with VIPT cache, and I think it is not ARM-specific: int val = 0x11111111; fd = open("abc", O_RDWR); addr = mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_SHARED, fd, 0); *(addr+0) = 0x44444444; tmp = *(addr+0); *(addr+1) = 0x77777777; write(fd, &val, sizeof(int)); close(fd); The results are not always 0x11111111 0x77777777 at the beginning as expected. Sometimes we see 0x44444444 0x77777777. Signed-off-by: Anfei <> Cc: Russell King <> Cc: Miklos Szeredi <> Cc: Nick Piggin <> Cc: <> Cc: <> Signed-off-by: Andrew Morton <> Signed-off-by: Linus Torvalds <>
Diffstat (limited to 'mm/filemap.c')
1 files changed, 3 insertions, 0 deletions
diff --git a/mm/filemap.c b/mm/filemap.c
index e3736923220..698ea80f210 100644
--- a/mm/filemap.c
+++ b/mm/filemap.c
@@ -2232,6 +2232,9 @@ again:
if (unlikely(status))
+ if (mapping_writably_mapped(mapping))
+ flush_dcache_page(page);
copied = iov_iter_copy_from_user_atomic(page, i, offset, bytes);