path: root/fs
diff options
authorDave Chinner <>2008-12-04 09:09:34 +1100
committerLachlan McIlroy <>2008-12-05 15:39:13 +1100
commit576a488a27f267af203f3ea69c700a1612335e9f (patch)
tree8c2cad9d20c5153a3eaa0b7f0b9259ac9a4fd676 /fs
parentfeaf3848a813a106f163013af6fcf6c4bfec92d9 (diff)
[XFS] Fix hang after disallowed rename across directory quota domains
When project quota is active and is being used for directory tree quota control, we disallow rename outside the current directory tree. This requires a check to be made after all the inodes involved in the rename are locked. We fail to unlock the inodes correctly if we disallow the rename when the target is outside the current directory tree. This results in a hang on the next access to the inodes involved in failed rename. Reported-by: Arkadiusz Miskiewicz <> Signed-off-by: Dave Chinner <> Tested-by: Arkadiusz Miskiewicz <> Signed-off-by: Lachlan McIlroy <>
Diffstat (limited to 'fs')
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/xfs/xfs_rename.c b/fs/xfs/xfs_rename.c
index d700dacdb10..c903130be7f 100644
--- a/fs/xfs/xfs_rename.c
+++ b/fs/xfs/xfs_rename.c
@@ -212,7 +212,7 @@ xfs_rename(
if (unlikely((target_dp->i_d.di_flags & XFS_DIFLAG_PROJINHERIT) &&
(target_dp->i_d.di_projid != src_ip->i_d.di_projid))) {
- xfs_rename_unlock4(inodes, XFS_ILOCK_SHARED);
+ xfs_rename_unlock4(inodes, XFS_ILOCK_EXCL);
xfs_trans_cancel(tp, cancel_flags);
goto std_return;