path: root/drivers
diff options
authorStephen M. Cameron <>2008-12-18 14:55:11 +0100
committerJens Axboe <>2008-12-19 08:14:07 +0100
commitd8a0be6ab7ba1ffa43e7ea0dcdde3e8b68d4f762 (patch)
treeb0e66e1dddaea05d9bc0b85461ffd058229a672f /drivers
parent929096fe9ff1f4b3645cf3919527ab47e8d5e17c (diff)
cciss: fix problem that deleting multiple logical drives could cause a panic
Fix problem that deleting multiple logical drives could cause a panic. It fixes a panic which can be easily reproduced in the following way: Just create several "arrays," each with multiple logical drives via hpacucli, then delete the first array, and it will blow up in deregister_disk(), in the call to get_host() when it tries to dig the hba pointer out of a NULL queue pointer. The problem has been present since my code to make rebuild_lun_table behave better went in. Signed-off-by: Stephen M. Cameron <> Signed-off-by: Jens Axboe <>
Diffstat (limited to 'drivers')
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c
index 9364dc55425..9f7c543cc04 100644
--- a/drivers/block/cciss.c
+++ b/drivers/block/cciss.c
@@ -1693,6 +1693,11 @@ static int rebuild_lun_table(ctlr_info_t *h, int first_time)
for (i = 0; i <= h->highest_lun; i++) {
int j;
drv_found = 0;
+ /* skip holes in the array from already deleted drives */
+ if (h->drv[i].raid_level == -1)
+ continue;
for (j = 0; j < num_luns; j++) {
memcpy(&lunid, &ld_buff->LUN[j][0], 4);
lunid = le32_to_cpu(lunid);