path: root/drivers
diff options
authorNeil Horman <>2008-12-17 16:07:47 -0800
committerJesse Barnes <>2008-12-17 16:07:47 -0800
commit3e3d0e9246d0eccc1da800348fc1b9199ae3d768 (patch)
treec9aa0988205a5879b7a9d7b8cb2972c45636e719 /drivers
parentb6adc1955d31515be6631e63b1fe4bcdcd41db77 (diff)
PCI hotplug: ibmphp: Fix module ref count underflow
I happened to notice that the ibmphp hotplug driver does something rather silly in its init routine. It purposely calls module_put so as to underflow its module ref count to avoid being removed from the kernel. This is bad practice, and wrong, since it provides a window for subsequent module_gets to reset the refcount to zero, allowing an unload to race in and cause all sorts of mysterious panics. If the module is unsafe to load, simply omitting the module_exit parameter is sufficient to prevent the kernel from allowing the unload. Acked-by: Greg Kroah-Hartman <> Signed-off-by: Neil Horman <> Signed-off-by: Jesse Barnes <>
Diffstat (limited to 'drivers')
1 files changed, 0 insertions, 5 deletions
diff --git a/drivers/pci/hotplug/ibmphp_core.c b/drivers/pci/hotplug/ibmphp_core.c
index c892daae74d..633e743442a 100644
--- a/drivers/pci/hotplug/ibmphp_core.c
+++ b/drivers/pci/hotplug/ibmphp_core.c
@@ -1402,10 +1402,6 @@ static int __init ibmphp_init(void)
goto error;
- /* lock ourselves into memory with a module
- * count of -1 so that no one can unload us. */
- module_put(THIS_MODULE);
return rc;
@@ -1423,4 +1419,3 @@ static void __exit ibmphp_exit(void)