aboutsummaryrefslogtreecommitdiff
path: root/net/rose
diff options
context:
space:
mode:
authorBen Hutchings <ben@decadent.org.uk>2009-12-14 16:05:09 +0000
committerDavid S. Miller <davem@davemloft.net>2010-01-03 21:18:40 -0800
commit35bb5cadc8c7b1462df57e32e08d964f1be7a75c (patch)
treebc8c8182bfba02caaf3f571e22dfc5581f2d0aa8 /net/rose
parentb3319b10523d8dac82b134a05de2a403119abebd (diff)
via-velocity: Give RX descriptors to the NIC later on open or MTU change
velocity_open() calls velocity_give_many_rx_descs(), which gives RX descriptors to the NIC, before installing an interrupt handler or calling velocity_init_registers(). I think this is very unsafe and it appears to explain the bug report <http://bugs.debian.org/508527>. On MTU change, velocity_give_many_rx_descs() is again called before velocity_init_registers(). I'm not sure whether this is unsafe but it does look wrong. Therefore, move the calls to velocity_give_many_rx_descs() after request_irq() and velocity_init_registers(). Signed-off-by: Ben Hutchings <ben@decadent.org.uk> Tested-by: Jan Ceuleers <jan.ceuleers@computer.org> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/rose')
0 files changed, 0 insertions, 0 deletions