diff options
author | James Bottomley <James.Bottomley@suse.de> | 2011-04-22 10:39:59 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2011-05-09 15:06:35 -0700 |
commit | 1f74c190e1e97a38823c07fdc71780580a0fc03f (patch) | |
tree | d43044a1069b1cf6a7757a73302028900d5fc3a2 /drivers/scsi/g_NCR5380.c | |
parent | 52adc5764d7cbeddce5e70aac1a14f534d004b60 (diff) |
put stricter guards on queue dead checks
commit 86cbfb5607d4b81b1a993ff689bbd2addd5d3a9b upstream.
SCSI uses request_queue->queuedata == NULL as a signal that the queue
is dying. We set this state in the sdev release function. However,
this allows a small window where we release the last reference but
haven't quite got to this stage yet and so something will try to take
a reference in scsi_request_fn and oops. It's very rare, but we had a
report here, so we're pushing this as a bug fix
The actual fix is to set request_queue->queuedata to NULL in
scsi_remove_device() before we drop the reference. This causes
correct automatic rejects from scsi_request_fn as people who hold
additional references try to submit work and prevents anything from
getting a new reference to the sdev that way.
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/scsi/g_NCR5380.c')
0 files changed, 0 insertions, 0 deletions