aboutsummaryrefslogtreecommitdiff
path: root/drivers/hid/hidraw.c
diff options
context:
space:
mode:
authorJiri Kosina <jkosina@suse.cz>2008-09-17 19:41:58 +0200
committerJiri Kosina <jkosina@suse.cz>2008-10-14 23:51:00 +0200
commit2b107d629dc0c35de606bb7b010b829cd247a93a (patch)
treec287d509c0a16a2c7d30b00d413a8a3b81e5188a /drivers/hid/hidraw.c
parentd92870ddd248e8c2562a8c4047885d3ad221ece7 (diff)
downloadlinux-2.6.38-lt-ux500-2b107d629dc0c35de606bb7b010b829cd247a93a.tar.gz
HID: fix incorrent length condition in hidraw_write()
The bound check on the buffer length if (count > HID_MIN_BUFFER_SIZE) is of course incorrent, the proper check is if (count > HID_MAX_BUFFER_SIZE) Fix it. Reported-by: Jerry Ryle <jerry@mindtribe.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'drivers/hid/hidraw.c')
-rw-r--r--drivers/hid/hidraw.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hid/hidraw.c b/drivers/hid/hidraw.c
index 4be240e74d4..497e0d1dd3c 100644
--- a/drivers/hid/hidraw.c
+++ b/drivers/hid/hidraw.c
@@ -113,7 +113,7 @@ static ssize_t hidraw_write(struct file *file, const char __user *buffer, size_t
if (!dev->hid_output_raw_report)
return -ENODEV;
- if (count > HID_MIN_BUFFER_SIZE) {
+ if (count > HID_MAX_BUFFER_SIZE) {
printk(KERN_WARNING "hidraw: pid %d passed too large report\n",
task_pid_nr(current));
return -EINVAL;