aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJiri Kosina <jkosina@suse.cz>2010-11-18 16:28:43 +0100
committerJiri Kosina <jkosina@suse.cz>2010-11-18 16:30:52 +0100
commitedd2126aa8aab8a87db7cc480d5047e9280d7acf (patch)
tree80c7d5b668f60e375344df3b2b3bd2d97fa0cba5
parentc311598b29f09c5092747a2603700f96a7daec2a (diff)
downloadlinux-2.6.38-lt-ux500-edd2126aa8aab8a87db7cc480d5047e9280d7acf.tar.gz
HID: wacom: make sysfs permissions more strict
It's not really dangerous in this driver, but it's against general practice and worth fixing. Wacom uses the attribute for changing the reporting speed of the tablet (and this actually requires poking the device in the background) (still I wouldn't consider it a security issue though). udev is a proper place to handle this. Reported-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
-rw-r--r--drivers/hid/hid-wacom.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hid/hid-wacom.c b/drivers/hid/hid-wacom.c
index 724f46ed612..94caae73138 100644
--- a/drivers/hid/hid-wacom.c
+++ b/drivers/hid/hid-wacom.c
@@ -172,7 +172,7 @@ static ssize_t wacom_store_speed(struct device *dev,
return -EINVAL;
}
-static DEVICE_ATTR(speed, S_IRUGO | S_IWUGO,
+static DEVICE_ATTR(speed, S_IRUGO | S_IWUSR | S_IWGRP,
wacom_show_speed, wacom_store_speed);
static int wacom_raw_event(struct hid_device *hdev, struct hid_report *report,