aboutsummaryrefslogtreecommitdiff
path: root/net/ipv6/ip6mr.c
diff options
context:
space:
mode:
authorDan Carpenter <error27@gmail.com>2010-05-26 00:38:56 -0700
committerDavid S. Miller <davem@davemloft.net>2010-05-26 00:38:56 -0700
commited0f160ad674407adb3aba499444f71c83289c63 (patch)
tree39cff780164f55d6cda23018431ab553c4477f9e /net/ipv6/ip6mr.c
parentd938a702e5ce8909ea68be97566150507bfea4df (diff)
downloadlinux-2.6.34-ux500-ed0f160ad674407adb3aba499444f71c83289c63.tar.gz
ipmr: off by one in __ipmr_fill_mroute()
This fixes a smatch warning: net/ipv4/ipmr.c +1917 __ipmr_fill_mroute(12) error: buffer overflow '(mrt)->vif_table' 32 <= 32 The ipv6 version had the same issue. Signed-off-by: Dan Carpenter <error27@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv6/ip6mr.c')
-rw-r--r--net/ipv6/ip6mr.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv6/ip6mr.c b/net/ipv6/ip6mr.c
index bd9e7d3e9c8..073071f2b75 100644
--- a/net/ipv6/ip6mr.c
+++ b/net/ipv6/ip6mr.c
@@ -2017,7 +2017,7 @@ static int __ip6mr_fill_mroute(struct mr6_table *mrt, struct sk_buff *skb,
struct rtattr *mp_head;
/* If cache is unresolved, don't try to parse IIF and OIF */
- if (c->mf6c_parent > MAXMIFS)
+ if (c->mf6c_parent >= MAXMIFS)
return -ENOENT;
if (MIF_EXISTS(mrt, c->mf6c_parent))