|author||Mingming Cao <firstname.lastname@example.org>||2008-07-25 01:46:22 -0700|
|committer||Linus Torvalds <email@example.com>||2008-07-25 10:53:32 -0700|
jbd: fix race between free buffer and commit transaction
journal_try_to_free_buffers() could race with jbd commit transaction when the later is holding the buffer reference while waiting for the data buffer to flush to disk. If the caller of journal_try_to_free_buffers() request tries hard to release the buffers, it will treat the failure as error and return back to the caller. We have seen the directo IO failed due to this race. Some of the caller of releasepage() also expecting the buffer to be dropped when passed with GFP_KERNEL mask to the releasepage()->journal_try_to_free_buffers(). With this patch, if the caller is passing the __GFP_WAIT and __GFP_FS to indicating this call could wait, in case of try_to_free_buffers() failed, let's waiting for journal_commit_transaction() to finish commit the current committing transaction, then try to free those buffers again. [firstname.lastname@example.org: coding-style fixes] Signed-off-by: Mingming Cao <email@example.com> Reviewed-by: Badari Pulavarty <firstname.lastname@example.org> Acked-by: Jan Kara <email@example.com> Signed-off-by: Andrew Morton <firstname.lastname@example.org> Signed-off-by: Linus Torvalds <email@example.com>
Diffstat (limited to 'mm')
1 files changed, 1 insertions, 2 deletions
diff --git a/mm/filemap.c b/mm/filemap.c
index 7675b91f4f6..5d4c880d7cd 100644
@@ -2563,9 +2563,8 @@ EXPORT_SYMBOL(generic_file_aio_write);
* Otherwise return zero.
* The @gfp_mask argument specifies whether I/O may be performed to release
- * this page (__GFP_IO), and whether the call may block (__GFP_WAIT).
+ * this page (__GFP_IO), and whether the call may block (__GFP_WAIT & __GFP_FS).
- * NOTE: @gfp_mask may go away, and this function may become non-blocking.
int try_to_release_page(struct page *page, gfp_t gfp_mask)