aboutsummaryrefslogtreecommitdiff
path: root/net/netlabel/netlabel_kapi.c
diff options
context:
space:
mode:
authorSerge E. Hallyn <serue@us.ibm.com>2008-02-04 22:29:47 -0800
committerLinus Torvalds <torvalds@woody.linux-foundation.org>2008-02-05 09:44:20 -0800
commit97829955ad291acec1d8b94e9911b3ceb1118bb1 (patch)
tree4af91977d82494375e09a961594f83ca77f253d7 /net/netlabel/netlabel_kapi.c
parent3b7391de67da515c91f48aa371de77cb6cc5c07e (diff)
downloadlinux-linaro-97829955ad291acec1d8b94e9911b3ceb1118bb1.tar.gz
oom_kill: remove uid==0 checks
Root processes are considered more important when out of memory and killing proceses. The check for CAP_SYS_ADMIN was augmented with a check for uid==0 or euid==0. There are several possible ways to look at this: 1. uid comparisons are unnecessary, trust CAP_SYS_ADMIN alone. However CAP_SYS_RESOURCE is the one that really means "give me extra resources" so allow for that as well. 2. Any privileged code should be protected, but uid is not an indication of privilege. So we should check whether any capabilities are raised. 3. uid==0 makes processes on the host as well as in containers more important, so we should keep the existing checks. 4. uid==0 makes processes only on the host more important, even without any capabilities. So we should be keeping the (uid==0||euid==0) check but only when userns==&init_user_ns. I'm following number 1 here. Signed-off-by: Serge Hallyn <serue@us.ibm.com> Cc: Andrew Morgan <morgan@kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'net/netlabel/netlabel_kapi.c')
0 files changed, 0 insertions, 0 deletions