|author||Amit Shah <firstname.lastname@example.org>||2011-03-14 17:45:48 +0530|
|committer||Greg Kroah-Hartman <email@example.com>||2011-05-02 09:19:44 -0700|
virtio: console: Enable call to hvc_remove() on console port remove
commit afa2689e19073cd2e762d0f2c1358fab1ab9f18c upstream. This call was disabled as hot-unplugging one virtconsole port led to another virtconsole port freezing. Upon testing it again, this now works, so enable it. In addition, a bug was found in qemu wherein removing a port of one type caused the guest output from another port to stop working. I doubt it was just this bug that caused it (since disabling the hvc_remove() call did allow other ports to continue working), but since it's all solved now, we're fine with hot-unplugging of virtconsole ports. Signed-off-by: Amit Shah <firstname.lastname@example.org> Signed-off-by: Rusty Russell <email@example.com> Signed-off-by: Greg Kroah-Hartman <firstname.lastname@example.org>
Diffstat (limited to 'drivers/char')
1 files changed, 0 insertions, 11 deletions
diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c
index 84b164d1eb2..838568a7dbf 100644
@@ -1280,18 +1280,7 @@ static void unplug_port(struct port *port)
- * hvc_remove() not called as removing one hvc port
- * results in other hvc ports getting frozen.
- * Once this is resolved in hvc, this functionality
- * will be enabled. Till that is done, the -EPIPE
- * return from get_chars() above will help
- * hvc_console.c to clean up on ports we remove here.
/* Remove unused data this port might have received. */