From 7013c06124e9760f75ef194d429ed29fba843eb9 Mon Sep 17 00:00:00 2001 From: Thomas Weber Date: Wed, 24 Nov 2010 13:07:51 +0100 Subject: Common/command: Guard strchr/strlen from NULL pointer Guard strchr/strlen from being called with NULL pointer. This line is crashing when command "env" is called without subcommand. The cmd is NULL in this case because the calling function "do_env" decremented the argc without checking if there are still arguments available. Signed-off-by: Thomas Weber --- common/command.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/common/command.c b/common/command.c index 0020eacf5..0b1a3fbf9 100644 --- a/common/command.c +++ b/common/command.c @@ -108,6 +108,8 @@ cmd_tbl_t *find_cmd_tbl (const char *cmd, cmd_tbl_t *table, int table_len) int len; int n_found = 0; + if (!cmd) + return NULL; /* * Some commands allow length modifiers (like "cp.b"); * compare command name only until first dot. -- cgit v1.2.3