aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDave Barnish <dave.barnish@arm.com>2013-10-31 12:03:20 +0000
committerDave Barnish <dave.barnish@arm.com>2013-10-31 13:26:55 +0000
commit77f25d451ad2e3e65dccd164243387df7a78f1e3 (patch)
tree759631ea6586f38b4d4edf866d7292165c7e33e5
parent45b8cd24c36a52176e3fcf24cca26fb6c9a7f652 (diff)
downloadxf86-video-armsoc-77f25d451ad2e3e65dccd164243387df7a78f1e3.tar.gz
Use flag settings for a non-scanout buffer in all cases for exynos drm.
Using the correct settings for the dumb buffer create flags causes problems for chromebook so we use the non-scanout setting in both cases. This is okay for mainline drm which effectively always creates scanout buffers anyway. Change-Id: Icaee2a519b83c089c6aa939569d75796af230849
-rw-r--r--src/drmmode_exynos/drmmode_exynos.c8
1 files changed, 7 insertions, 1 deletions
diff --git a/src/drmmode_exynos/drmmode_exynos.c b/src/drmmode_exynos/drmmode_exynos.c
index f1fa033..17b8ec4 100644
--- a/src/drmmode_exynos/drmmode_exynos.c
+++ b/src/drmmode_exynos/drmmode_exynos.c
@@ -52,7 +52,13 @@ struct drm_exynos_plane_set_zpos {
#define DRM_IOCTL_EXYNOS_PLANE_SET_ZPOS DRM_IOWR(DRM_COMMAND_BASE + \
DRM_EXYNOS_PLANE_SET_ZPOS, struct drm_exynos_plane_set_zpos)
-#define EXYNOS_SCANOUT_FLAGS 0x00000000
+/* TODO MIDEGL-1845: EXYNOS_SCANOUT_FLAGS should be defined as 0x00000000 but
+ * this causes problems for chromebook. Leaving it at 0x00000001 here doesn't
+ * adversely affect mainline exynos DRM as it effectively always uses
+ * contiguous memory. See kernel file drivers/gpu/drm/exynos/exynos_drm_buf.c
+ * function lowlevel_buffer_allocate().
+ */
+#define EXYNOS_SCANOUT_FLAGS 0x00000001
#define EXYNOS_NON_SCANOUT_FLAGS 0x00000001
static int init_plane_for_cursor(int drm_fd, uint32_t plane_id)