diff options
| author | Chris Redpath <chris.redpath@arm.com> | 2012-06-29 16:07:46 +0100 |
|---|---|---|
| committer | Jon Medhurst <tixy@linaro.org> | 2012-07-16 14:21:44 +0100 |
| commit | 7ebcf75725f709a907a99e272c639630f0bb0f10 (patch) | |
| tree | 8b8848c7407e7faeea5526c9de63919fe843a0b1 | |
| parent | 576e390e935c7a840e0d413a3677da505bfded3d (diff) | |
ARM HDLCD: Review comments from Liviu - extraneous memcpy
Signed-off-by: Chris Redpath <chris.redpath@arm.com>
Reviewed-By: Liviu Dudau <liviu.dudau@arm.com>
| -rw-r--r-- | drivers/video/arm-hdlcd.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/video/arm-hdlcd.c b/drivers/video/arm-hdlcd.c index 050721d5e88..27c52e494b0 100644 --- a/drivers/video/arm-hdlcd.c +++ b/drivers/video/arm-hdlcd.c @@ -262,10 +262,10 @@ static int hdlcd_set_par(struct fb_info *info) if (!memcmp(&info->var, &cached_var_screeninfo, sizeof(struct fb_var_screeninfo))) { if(old_yoffset != info->var.yoffset) { - /* we only changed yoffset */ + /* we only changed yoffset, and we already + * already recorded it a couple lines up + */ hdlcd_pan_display(&info->var, info); - memcpy(&cached_var_screeninfo, &info->var, - sizeof(struct fb_var_screeninfo)); } /* or no change */ return 0; |