aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJason Low <jason.low2@hp.com>2015-02-13 11:58:07 +0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2015-03-26 15:06:54 +0100
commit0588215aed7f4a280ef87f87eca0862222cc0b7b (patch)
treedad31dc9a64cd6407906ae4c3dbabe1df4ec53ad
parent28a4e9536385dcb35c242c464c19ae0dca76ef78 (diff)
cpuset: Fix cpuset sched_relax_domain_level
commit 283cb41f426b723a0255702b761b0fc5d1b53a81 upstream. The cpuset.sched_relax_domain_level can control how far we do immediate load balancing on a system. However, it was found on recent kernels that echo'ing a value into cpuset.sched_relax_domain_level did not reduce any immediate load balancing. The reason this occurred was because the update_domain_attr_tree() traversal did not update for the "top_cpuset". This resulted in nothing being changed when modifying the sched_relax_domain_level parameter. This patch is able to address that problem by having update_domain_attr_tree() allow updates for the root in the cpuset traversal. Fixes: fc560a26acce ("cpuset: replace cpuset->stack_list with cpuset_for_each_descendant_pre()") Signed-off-by: Jason Low <jason.low2@hp.com> Signed-off-by: Zefan Li <lizefan@huawei.com> Signed-off-by: Tejun Heo <tj@kernel.org> Tested-by: Serge Hallyn <serge.hallyn@canonical.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--kernel/cpuset.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/kernel/cpuset.c b/kernel/cpuset.c
index 2fb2877e6961..7b4530b0b16b 100644
--- a/kernel/cpuset.c
+++ b/kernel/cpuset.c
@@ -503,9 +503,6 @@ static void update_domain_attr_tree(struct sched_domain_attr *dattr,
rcu_read_lock();
cpuset_for_each_descendant_pre(cp, pos_css, root_cs) {
- if (cp == root_cs)
- continue;
-
/* skip the whole subtree if @cp doesn't have any CPU */
if (cpumask_empty(cp->cpus_allowed)) {
pos_css = css_rightmost_descendant(pos_css);